Skip to content

Removing deprecated batching code specific to NN Descent #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Aug 18, 2025
Merged

Removing deprecated batching code specific to NN Descent #1249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b50ea5
remove nnd specific batching code
jinsolp Aug 12, 2025
0aa87b8
rm nnd specific batching
jinsolp Aug 13, 2025
654d6a4
merge commit
jinsolp Aug 14, 2025
07e593f
merge conflict fix
jinsolp Aug 14, 2025
6e4ba63
Merge branch 'branch-25.10' into improve/rm-batch-nnd
jinsolp Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cpp/include/cuvs/neighbors/nn_descent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2024, NVIDIA CORPORATION.
* Copyright (c) 2024-2025, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -54,7 +54,6 @@ struct cuvsNNDescentIndexParams {
size_t max_iterations;
float termination_threshold;
bool return_distances;
size_t n_clusters;
};

typedef struct cuvsNNDescentIndexParams* cuvsNNDescentIndexParams_t;
Expand Down
3 changes: 1 addition & 2 deletions cpp/include/cuvs/neighbors/nn_descent.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023-2024, NVIDIA CORPORATION.
* Copyright (c) 2023-2025, NVIDIA CORPORATION.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -56,7 +56,6 @@ struct index_params : cuvs::neighbors::index_params {
size_t max_iterations = 20; // Number of nn-descent iterations.
float termination_threshold = 0.0001; // Termination threshold of nn-descent.
bool return_distances = true; // return distances if true
size_t n_clusters = 1; // defaults to not using any batching

/** @brief Construct NN descent parameters for a specific kNN graph degree
*
Expand Down
Loading