Skip to content

[Improvement] Replace Calls to thrust::transform with raft::linalg#1238

Merged
rapids-bot[bot] merged 24 commits intorapidsai:branch-25.10from
tarang-jain:thrust-raft-swap
Aug 13, 2025
Merged

[Improvement] Replace Calls to thrust::transform with raft::linalg#1238
rapids-bot[bot] merged 24 commits intorapidsai:branch-25.10from
tarang-jain:thrust-raft-swap

Conversation

@tarang-jain
Copy link
Copy Markdown
Contributor

@tarang-jain tarang-jain commented Aug 11, 2025

No description provided.

@tarang-jain tarang-jain requested review from a team as code owners August 11, 2025 20:19
@tarang-jain tarang-jain marked this pull request as draft August 11, 2025 20:19
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Aug 11, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tarang-jain tarang-jain added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 11, 2025
@tarang-jain tarang-jain self-assigned this Aug 11, 2025
@tarang-jain tarang-jain marked this pull request as ready for review August 11, 2025 22:53
@tarang-jain tarang-jain removed request for a team and KyleFromNVIDIA August 12, 2025 16:16
@tarang-jain tarang-jain changed the title [WIP] [Improvement] [Binary Size] Replace Calls to thrust::transform with raft::linalg [Improvement] Replace Calls to thrust::transform with raft::linalg Aug 12, 2025
jinsolp
jinsolp approved these changes Aug 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tarang, LGTM! Approving with one minor comment.

Comment thread cpp/src/sparse/neighbors/detail/cross_component_nn.cuh Outdated
lowener
lowener reviewed Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lowener lowener left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tarang, looks good. I just have minor remarks to re-use raft::identity_op

Comment thread examples/cpp/src/ivf_flat_example.cu Outdated
Comment thread cpp/tests/neighbors/ann_ivf_flat.cuh Outdated
Comment thread cpp/tests/neighbors/ann_ivf_flat.cuh Outdated
Comment thread cpp/src/neighbors/ball_cover/ball_cover.cuh Outdated
lowener
lowener approved these changes Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@lowener lowener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lowener
Copy link
Copy Markdown
Contributor

lowener commented Aug 13, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 378440e into rapidsai:branch-25.10 Aug 13, 2025
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lowener lowener lowener approved these changes

@jinsolp jinsolp jinsolp approved these changes

Assignees

@tarang-jain tarang-jain

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

Unstructured Data Processing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tarang-jain @lowener @jinsolp