-
Notifications
You must be signed in to change notification settings - Fork 184
Refactor knn graph build params to remove graph_build_types.hpp
#1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
1388301
proper enum
jinsolp 5a69753
refactor graph build params
jinsolp 0f910b4
Merge branch 'branch-25.10' into refactor-graph-build-types
jinsolp 50158a8
Merge branch 'branch-25.10' into refactor-graph-build-types
jinsolp 8fd74d3
Merge branch 'branch-25.10' into refactor-graph-build-types
jinsolp 26c0d4c
resolve merge conflict
jinsolp 370523a
adjust headers after merge conflict
jinsolp a090944
Merge branch 'main' into refactor-graph-build-types
jinsolp fbb1134
Merge branch 'main' into refactor-graph-build-types
jinsolp 4deffb9
hnsw header
jinsolp 1b4835b
resolve merge conflicts
jinsolp b68969e
merge
jinsolp 1832e41
Merge branch 'main' into refactor-graph-build-types
jinsolp eaf6f3e
rm graph_build_types.hpp
jinsolp 6f517fe
Merge branch 'main' into refactor-graph-build-types
jinsolp 405a815
Merge branch 'main' into refactor-graph-build-types
jinsolp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder- could we put these in all_neighbors.hpp and include in cagra.hpp? I know it sounds awkward to do this today, but if we consider that CAGRA will be using all_neighbors soon to build the underlying all-neighbors graph then that'll feel more natural. We could even add a comment in cagra.hpp where we include all_neighbors.hpp, stating that CAGRA shoudl beusing that soon (and maybe link to a Github issue so we remember to remove the comment eventually).