[BUG] NEIGHBORS_ALL_NEIGHBORS_TEST build ignores --no-mg#1230
Merged
rapids-bot[bot] merged 12 commits intorapidsai:branch-25.10from Aug 28, 2025
Merged
Conversation
robertmaynard
requested changes
Aug 8, 2025
Contributor
robertmaynard
left a comment
There was a problem hiding this comment.
This can be simplified to:
ConfigureTest(
NAME NEIGHBORS_ALL_NEIGHBORS_TEST PATH neighbors/all_neighbors/test_float.cu GPUS 1 PERCENT 100
ADDITIONAL_DEP $<TARGET_NAME_IF_EXISTS:NCCL::NCCL>
)
jinsolp
reviewed
Aug 8, 2025
| ConfigureTest( | ||
| NAME NEIGHBORS_ALL_NEIGHBORS_TEST PATH neighbors/all_neighbors/test_float.cu GPUS 1 PERCENT 100 | ||
| ADDITIONAL_DEP NCCL::NCCL | ||
| ADDITIONAL_DEP ${NCCL_DEPS} |
Contributor
There was a problem hiding this comment.
Thanks for finding this! We can just get rid of this NCCL line altogether because this doesn't depend on nccl at all.
Member
Author
There was a problem hiding this comment.
Thank you @jinsolp for letting me know. I removed the line.
cjnolet
approved these changes
Aug 20, 2025
Member
|
@robertmaynard mind re-reviewing when you have a moment? |
robertmaynard
approved these changes
Aug 25, 2025
Member
|
/merge |
e02b7d1
into
rapidsai:branch-25.10
104 of 106 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following error occurs when building the unit tests on a machine where NCCL is not installed, even though the
--no-mgoption is specified.This is because
NCCL::NCCLis specified in tests/CmakeLists.txtcuvs/cpp/tests/CMakeLists.txt
Lines 213 to 216 in afc24ee
I could build the unit tests without the NCCL dependency. Is this dependency really necessary even when the
--no-mgoption is specified?This PR modifies the CMakeLists.txt file so that the NCCL dependency is set only when the
--no-mgoption is not specified.Rel: #785 vis: @jinsolp