Skip to content

[Java] Add CAGRA index graph accessor/build from graph (host memory)#1216

Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
ldematte:java/cagra-read-graph-cuvsmatrix
Aug 12, 2025
Merged

[Java] Add CAGRA index graph accessor/build from graph (host memory)#1216
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.10from
ldematte:java/cagra-read-graph-cuvsmatrix

Conversation

@ldematte
Copy link
Copy Markdown
Contributor

@ldematte ldematte commented Aug 5, 2025

This PR leverages the functions introduced by #1086 and the data structures introduced by #1111 to access, copy, and re-create an index to/from a CAGRA graph.

Supersedes #1105

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Aug 5, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ldematte ldematte changed the title [Java] Add CAGRA index graph accessor/build from graph (host memory) [Review][Java] Add CAGRA index graph accessor/build from graph (host memory) Aug 5, 2025
@ldematte
Copy link
Copy Markdown
Contributor Author

ldematte commented Aug 8, 2025

@mythrocks did you have a chance to look into this? Any comments?

@mythrocks
Copy link
Copy Markdown
Contributor

@mythrocks did you have a chance to look into this? Any comments?

Sorry, will do shortly.

@mythrocks mythrocks moved this to In Progress in Elasticsearch + cuVS Team Aug 8, 2025
@mythrocks mythrocks added feature request New feature or request non-breaking Introduces a non-breaking change Waiting for review labels Aug 8, 2025
@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test 5d2ef5b

Comment thread java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java Outdated
Comment thread java/cuvs-java/src/main/java22/com/nvidia/cuvs/internal/CagraIndexImpl.java Outdated
Copy link
Copy Markdown
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits, but this looks good to me, mostly. We'll need to discuss how to handle the case where the number of rows approaches max-int.

This needs to be rebased. (Sorry! #1215.)

@ldematte
Copy link
Copy Markdown
Contributor Author

@mythrocks rebased and addressed comments, thanks!

Copy link
Copy Markdown
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can address the graph-size problem as a follow-on.. I see that we're upping the int to a long. Thanks for addressing this.

@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test f4eb80b

@mythrocks mythrocks changed the title [Review][Java] Add CAGRA index graph accessor/build from graph (host memory) [Java] Add CAGRA index graph accessor/build from graph (host memory) Aug 11, 2025
@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test f4eb80b

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Aug 12, 2025

/ok to test f4eb80b

@mythrocks, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@mythrocks
Copy link
Copy Markdown
Contributor

/ok to test 7e380b5

@mythrocks
Copy link
Copy Markdown
Contributor

/merge

@rapids-bot rapids-bot Bot merged commit 34032a8 into rapidsai:branch-25.10 Aug 12, 2025
53 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Elasticsearch + cuVS Team Aug 12, 2025
@ldematte ldematte deleted the java/cagra-read-graph-cuvsmatrix branch August 12, 2025 09:02
enp1s0 pushed a commit to enp1s0/cuvs that referenced this pull request Aug 22, 2025
…apidsai#1216)

This PR leverages the functions introduced by rapidsai#1086 and the data structures introduced by rapidsai#1111 to access, copy, and re-create an index to/from a CAGRA graph.

Supersedes rapidsai#1105

Authors:
  - Lorenzo Dematté (https://github.com/ldematte)
  - MithunR (https://github.com/mythrocks)

Approvers:
  - MithunR (https://github.com/mythrocks)

URL: rapidsai#1216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change Waiting for review

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants