[Java] Add decorator for synchronized CuVSResource access#1209
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-25.10from Aug 5, 2025
Merged
Conversation
cjnolet
added
improvement
Contributor
|
/ok to test 2b2f0cd |
mythrocks
reviewed
Aug 4, 2025
| if (firstError.get() == null) { | ||
| firstError.set(e); | ||
| // Start all threads simultaneously to maximize contention | ||
| log.info("Starting all {} threads simultaneously...", numThreads); |
Contributor
There was a problem hiding this comment.
Not a problem for this PR here. But I would like the tests to run without noise on the screen. We've done this, to a degree, in the TieredIndex tests.
This test is far less noisy than some of the other (extant) ones. We'll address that separately.
Contributor
Author
There was a problem hiding this comment.
++ to review logging levels. Probably a bit of "info" level feedback is OK, but most statements should probably be debug or trace, so we can turn them on when needed.
Contributor
|
/ok to test d043cf8 |
Contributor
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
) As a follow up to rapidsai#1089 and rapidsai#1082, this PR introduces a decorator to ensure that access to a shared CuVSResource is synchronized. This could be useful in cases where application logic is complex and it's not easy to efficiently and cleanly guarantee that access to a CuVSResources is done by at most one thread at each given time. Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) URL: rapidsai#1209
enp1s0
pushed a commit
to enp1s0/cuvs
that referenced
this pull request
Aug 22, 2025
) As a follow up to rapidsai#1089 and rapidsai#1082, this PR introduces a decorator to ensure that access to a shared CuVSResource is synchronized. This could be useful in cases where application logic is complex and it's not easy to efficiently and cleanly guarantee that access to a CuVSResources is done by at most one thread at each given time. Authors: - Lorenzo Dematté (https://github.com/ldematte) - MithunR (https://github.com/mythrocks) Approvers: - MithunR (https://github.com/mythrocks) URL: rapidsai#1209
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to #1089 and #1082, this PR introduces a decorator to ensure that access to a shared CuVSResource is synchronized. This could be useful in cases where application logic is complex and it's not easy to efficiently and cleanly guarantee that access to a CuVSResources is done by at most one thread at each given time.