Skip to content

Remove unused templated instances#1204

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from
vinaydes:remove-unused-instances
Jul 31, 2025
Merged

Remove unused templated instances#1204
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.10from
vinaydes:remove-unused-instances

Conversation

@vinaydes
Copy link
Copy Markdown
Contributor

The fusedDistanceNNMinReduce is not documented or exposed downstream, so removing it. This reduced libcuvs.so size by ~0.5 MB, when I compiled for single arch.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jul 31, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change Waiting for review labels Jul 31, 2025
@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jul 31, 2025

/ok to test 816b23c

@cjnolet
Copy link
Copy Markdown
Member

cjnolet commented Jul 31, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 60e8af2 into rapidsai:branch-25.10 Jul 31, 2025
56 checks passed
lowener pushed a commit to lowener/cuvs that referenced this pull request Aug 11, 2025
The `fusedDistanceNNMinReduce` is not documented or exposed downstream, so removing it. This reduced libcuvs.so size by ~0.5 MB, when I compiled for single arch.

Authors:
  - Vinay Deshpande (https://github.com/vinaydes)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1204
enp1s0 pushed a commit to enp1s0/cuvs that referenced this pull request Aug 22, 2025
The `fusedDistanceNNMinReduce` is not documented or exposed downstream, so removing it. This reduced libcuvs.so size by ~0.5 MB, when I compiled for single arch.

Authors:
  - Vinay Deshpande (https://github.com/vinaydes)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1204
@vinaydes vinaydes deleted the remove-unused-instances branch January 27, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change Waiting for review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants