Fix for hellinger metric#1128
Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-25.08from Jul 23, 2025
Merged
Conversation
tarang-jain
reviewed
Jul 22, 2025
tarang-jain
approved these changes
Jul 23, 2025
viclafargue
added
bug
cjnolet
approved these changes
Jul 23, 2025
Member
|
/merge |
github-project-automation
Bot
moved this from Todo
to Done
in Unstructured Data Processing
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
The implementation of the distance function for the `hellinger` metric had two issues : 1) It did not restore data integrity correctly : double `sqrt` operation 2) It did not check for data overlap (two data chunks/tiles in the pairwise operation have overlapping data). Authors: - Victor Lafargue (https://github.com/viclafargue) Approvers: - Tarang Jain (https://github.com/tarang-jain) - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the distance function for the
hellingermetric had two issues :sqrtoperationCloses rapidsai/cuml#7011