Conditionally post process distances in NN Descent for use with distance epilogue#1108
Merged
rapids-bot[bot] merged 10 commits intorapidsai:branch-25.08from Jul 23, 2025
Merged
Conversation
jinsolp
added
bug
cjnolet
approved these changes
Jul 23, 2025
Contributor
Author
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
lowener
pushed a commit
to lowener/cuvs
that referenced
this pull request
Aug 11, 2025
…nce epilogue (rapidsai#1108) Current implementation of nn descent post processes distances for `L2SqrtExpanded` and `InnerProduct` for efficiency. However, this may cause issues when using a distance epilogue. This PR checks if distances can be postprocessed based on the distance epilogue type, and if not, attempts to compute the full accurate distance instead of postprocessing. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#1108
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation of nn descent post processes distances for
L2SqrtExpandedandInnerProductfor efficiency.However, this may cause issues when using a distance epilogue.
This PR checks if distances can be postprocessed based on the distance epilogue type, and if not, attempts to compute the full accurate distance instead of postprocessing.