ReachabilityPostProcess distance epilogue for NN Descent#1073
Merged
rapids-bot[bot] merged 13 commits intorapidsai:branch-25.08from Jul 8, 2025
Merged
ReachabilityPostProcess distance epilogue for NN Descent#1073rapids-bot[bot] merged 13 commits intorapidsai:branch-25.08from
ReachabilityPostProcess distance epilogue for NN Descent#1073rapids-bot[bot] merged 13 commits intorapidsai:branch-25.08from
Conversation
jinsolp
added
feature request
cjnolet
reviewed
Jul 3, 2025
| * limitations under the License. | ||
| */ | ||
|
|
||
| #pragma once |
Member
There was a problem hiding this comment.
Not a reason to hold up this PR, but since cuVS is no longer header-only, we don't have to have these _types files anymore. We could just include this in the shared code (assuming there is a shared place to put it).
Contributor
Author
There was a problem hiding this comment.
Placed it back in reachability.cuh.
The mutual reachability function will be cleaned up in another PR, and the reachability.cuh file will eventually be left with only ReachabilityPostProcess struct.
cjnolet
approved these changes
Jul 3, 2025
Member
cjnolet
left a comment
cjnolet
left a comment
There was a problem hiding this comment.
This LGTM, but before we merge this we should take a look at the binary size just to make sure we're not adding a ton of size to it.
Contributor
Author
|
Compared to the nightly;
So looks okay : ) |
7 tasks
Member
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NN Descent changed to support distance epilogues. Currently supporting
ReachabilityPostProcessandidentity_op. A new distance epilogue will need new instantiations.Mutual reachability computation will eventually be hidden behind the
all_neighborsAPI. Basic tests are still added in this PR to ensure the correctness of this feature.