Instantiate only specific RAFT linewise kernels#1018
Merged
rapids-bot[bot] merged 18 commits intorapidsai:branch-25.08from Jul 2, 2025
Merged
Instantiate only specific RAFT linewise kernels#1018rapids-bot[bot] merged 18 commits intorapidsai:branch-25.08from
rapids-bot[bot] merged 18 commits intorapidsai:branch-25.08from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
aamijar
added
non-breaking
aamijar
commented
Jun 12, 2025
tarang-jain
requested changes
Jun 18, 2025
tarang-jain
reviewed
Jul 1, 2025
Contributor
tarang-jain
left a comment
tarang-jain
left a comment
There was a problem hiding this comment.
LGTM overall. CI is also passing so that is great. However, can you add the DO NOT MERGE tag to this PR until the raft PR #2701 is merged? (And also, a reminder to revert the changes to get_raft.cmake once the raft PR is merged)
Furthermore, can you report the libcuvs.so binary size reduction due to this change once the raft PR is merged?
Member
Author
|
Yes, updated the PR description and added the tag |
tarang-jain
approved these changes
Jul 2, 2025
divyegala
approved these changes
Jul 2, 2025
Member
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduces libcuvs binary size by 4.21 MB
Depends on rapidsai/raft#2701 and Resolves rapidsai/raft#2682