Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

refactor CUDA versions in dependencies.yaml#1317

Merged
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.02from
jameslamb:rework-dependencies
Jan 11, 2024
Merged

refactor CUDA versions in dependencies.yaml#1317
rapids-bot[bot] merged 4 commits intorapidsai:branch-24.02from
jameslamb:rework-dependencies

Conversation

@jameslamb
Copy link
Member

@jameslamb jameslamb commented Jan 10, 2024

Description

Contributes to rapidsai/build-planning#7.

Proposes splitting the cuda-version dependency in dependencies.yaml out to its own thing, separate from the bits of the CUDA Toolkit this project needs.

Benefits of this change

  • prevents accidental inclusion of multiple cuda-version version in environments
  • reduces update effort (via enabling more use of globs like "12.*")
  • improves the chance that errors like "conda recipe is missing a dependency" are caught in CI

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 11, 2024
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise all good.

Co-authored-by: Vyas Ramasubramani <[email protected]>
@jameslamb
Copy link
Member Author

One job is failing, like this:

Collecting cudf-cu12==24.2.*,>=0.0.0a0
  Downloading https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/cudf-cu12/24.2.0a177/cudf_cu12-24.2.0a177-cp310-cp310-manylinux_2_28_x86_64.whl (426.2 MB)
     ━━━━━━━━━                                97.1/426.2 MB 7.5 MB/s eta 0:00:44
ERROR: Wheel 'cudf-cu12' located at /tmp/pip-unpack-rzwlblzl/cudf_cu12-24.2.0a177-cp310-cp310-manylinux_2_28_x86_64.whl is invalid.

(build link)

To me, that looks like the wheel download was interrupted, e.g. by some brief networking disruption. Pushed an empty commit to re-trigger CI.

@jakirkham
Copy link
Member

It looks like that cleared out

@bdice
Copy link
Contributor

bdice commented Jan 11, 2024

/merge

@rapids-bot rapids-bot bot merged commit 48f601b into rapidsai:branch-24.02 Jan 11, 2024
@jameslamb jameslamb mentioned this pull request Jan 11, 2024
@jameslamb jameslamb deleted the rework-dependencies branch January 11, 2024 18:59
rapids-bot bot pushed a commit that referenced this pull request Feb 10, 2024
* switches to CUDA 12.2.2 for building conda packages and wheels
* adds new tests running against CUDA 12.2.2
* adds some `"12.*"` globs in `dependencies.yaml` missed in #1317

### Notes for Reviewers

This is part of ongoing work to build and test packages against CUDA 12.2.2 across all of RAPIDS.

For more details see:

* rapidsai/build-planning#7
* rapidsai/shared-workflows#166

Planning a second round of PRs to revert these references back to a proper `branch-24.{nn}` release branch of `shared-workflows` once rapidsai/shared-workflows#166 is merged.

*(created with `rapids-reviser`)*

Authors:
  - James Lamb (https://github.com/jameslamb)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)
  - https://github.com/jakirkham

URL: #1320
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants