Skip to content

Pin openblas on aarch64#7933

Merged
rapids-bot[bot] merged 2 commits intorapidsai:release/26.04from
jcrist:pr-to-trigger-ci
Mar 30, 2026
Merged

Pin openblas on aarch64#7933
rapids-bot[bot] merged 2 commits intorapidsai:release/26.04from
jcrist:pr-to-trigger-ci

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Mar 30, 2026

We're seeing some test failures with the new openblas release on aarch64 (accuracy issues on comparison with sklearn's results, not issues in cuml's execution). I suspect a regression in openblas.

For now we pin openblas on aarch64.

@jcrist jcrist requested a review from a team as a code owner March 30, 2026 16:27
@jcrist jcrist requested a review from viclafargue March 30, 2026 16:27
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Mar 30, 2026
@jcrist jcrist added the DO NOT MERGE Hold off on merging; see PR for details label Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 30, 2026

📝 Walkthrough

Walkthrough

The PR adds version constraints on libopenblas (upper bound ≤0.3.30) across CUDA-specific aarch64 environment configurations and introduces an architecture-specific dependency override in the manifest file to enforce this constraint for aarch64 targets.

Changes

Cohort / File(s) Summary
Aarch64 CUDA Environment Files
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-131_arch-aarch64.yaml
Added libopenblas<=0.3.30 dependency constraint to both CUDA 12.9 and 13.1 aarch64 environment configurations.
Dependency Manifest
dependencies.yaml
Added architecture-specific output matrix override under dependencies.test_python.specific to enforce libopenblas<=0.3.30 for aarch64 targets in conda builds.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and specifically describes the main change: pinning openblas on aarch64 architecture, which matches the core modifications across all three modified files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description directly addresses the changeset by explaining test failures with openblas on aarch64 and pinning it to resolve accuracy issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@jcrist jcrist requested a review from a team as a code owner March 30, 2026 18:07
@jcrist jcrist requested a review from gforsyth March 30, 2026 18:07
@github-actions github-actions Bot added the conda conda issue label Mar 30, 2026
@jcrist jcrist force-pushed the pr-to-trigger-ci branch from 93bfae5 to 2f9d079 Compare March 30, 2026 18:43
@github-actions github-actions Bot removed the Cython / Python Cython or Python issue label Mar 30, 2026
@jcrist jcrist changed the title PR to trigger CI Pin openblas on aarch64 Mar 30, 2026
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed DO NOT MERGE Hold off on merging; see PR for details labels Mar 30, 2026
Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ok for now to unblock CI, but we'll want to figure it out soon-ish. I could see a ceiling like this causing problems (especially in the all-of-RAPIDS environments like the devcontainers) as we look to add new Python versions and update other versions of things.

@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Mar 30, 2026

Agreed that it's a stopgap. Once this is in I'll open a followup issue to investigate more. My brief observations are:

  • 0.3.32 (just released): many many failures. Could possibly be fixed by an increase in tolerances, but there's enough failures here (and a suspicious upstream issue) that I suspect an openblas regression.
  • 0.3.31 (released in jan, but for some reason wasn't used in our CI before???): only 2 small numeric failures, could be fixed by a slight increase in tolerances.

@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Mar 30, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 10be112 into rapidsai:release/26.04 Mar 30, 2026
116 checks passed
rapids-bot Bot pushed a commit to rapidsai/cuvs that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants