Skip to content

Small update to cuml-accel limitations#7929

Merged
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jcrist:update-cuml-accel-docs
Mar 25, 2026
Merged

Small update to cuml-accel limitations#7929
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jcrist:update-cuml-accel-docs

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Mar 24, 2026

  • Bump sklearn versions we test with.
  • Remove no longer relevant non-numeric limitation.

- Bump sklearn versions we test with.
- Remove no longer relevant non-numeric limitation.
@jcrist jcrist self-assigned this Mar 24, 2026
@jcrist jcrist requested a review from a team as a code owner March 24, 2026 21:55
@jcrist jcrist requested a review from betatim March 24, 2026 21:55
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cde83398-c401-4bb1-8277-fcab0bf95628

📥 Commits

Reviewing files that changed from the base of the PR and between 2076715 and f9ede9a.

📒 Files selected for processing (1)
  • docs/source/cuml-accel/limitations.rst

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Updated scikit-learn compatibility window from versions 1.4–1.7 to 1.5–1.8.
    • Removed guidance regarding pre-encoding of target values and string-label array requirements.

Walkthrough

Documentation update to limitations.rst that removes guidance requiring target variable pre-encoding into numeric form and updates the tested scikit-learn compatibility window from versions 1.4–1.7 to 1.5–1.8.

Changes

Cohort / File(s) Summary
Documentation Updates
docs/source/cuml-accel/limitations.rst
Removed guidance on pre-encoding target variable y into numeric/categorical form and removed reference to scikit-learn's LabelEncoder. Updated scikit-learn compatibility testing window from 1.4–1.7 to 1.5–1.8.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • viclafargue
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: a documentation update to the cuml-accel limitations file, updating sklearn versions and removing a non-numeric limitation.
Description check ✅ Passed The description is directly related to the changeset, listing the two main modifications: bumping sklearn versions and removing a non-numeric limitation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@betatim
Copy link
Copy Markdown
Member

betatim commented Mar 25, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 44c1e4e into rapidsai:release/26.04 Mar 25, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants