Skip to content

Remove xfailed cudf pandas tests#7901

Merged
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jcrist:remove-cudf-pandas-xfails
Mar 16, 2026
Merged

Remove xfailed cudf pandas tests#7901
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jcrist:remove-cudf-pandas-xfails

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Mar 16, 2026

Reverts xfails added in #7872

@jcrist jcrist self-assigned this Mar 16, 2026
@jcrist jcrist added the improvement Improvement / enhancement to an existing function label Mar 16, 2026
@jcrist jcrist requested a review from a team as a code owner March 16, 2026 16:35
@jcrist jcrist added the non-breaking Non-breaking change label Mar 16, 2026
@jcrist jcrist requested a review from betatim March 16, 2026 16:35
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Mar 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 7a91e08b-1c19-4043-b686-cf75a2bbccbb

📥 Commits

Reviewing files that changed from the base of the PR and between 4f00f71 and d1d92b2.

📒 Files selected for processing (4)
  • python/cuml/tests/test_doctest.py
  • python/cuml/tests/test_label_encoder.py
  • python/cuml/tests/test_one_hot_encoder.py
  • python/cuml/tests/test_ordinal_encoder.py
💤 Files with no reviewable changes (2)
  • python/cuml/tests/test_label_encoder.py
  • python/cuml/tests/test_ordinal_encoder.py

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Removed conditional skip logic from encoder test modules and doctest suite.
    • Previously xfailed tests now run unconditionally, improving test coverage and reliability.
    • Streamlined test parametrization for more consistent test behavior across environments.

Walkthrough

Removes cudf.pandas imports, conditional flags, and xfail test markers from multiple test files in the cuml test suite. The changes eliminate cudf.pandas-specific test conditional logic, allowing previously xfailed tests to run unconditionally and simplifying doctest parameterization.

Changes

Cohort / File(s) Summary
Doctest and encoder tests
python/cuml/tests/test_doctest.py, python/cuml/tests/test_label_encoder.py, python/cuml/tests/test_one_hot_encoder.py, python/cuml/tests/test_ordinal_encoder.py
Removed cudf.pandas imports, cudf_pandas_active flags, and associated xfail markers. Tests that were previously expected to fail when cudf.pandas was active now run unconditionally. Doctest iteration also simplified to use direct discovery instead of filtered parameterization.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • csadorf
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove xfailed cudf pandas tests' accurately summarizes the main change: removing xfail markers and cudf.pandas-related test logic across multiple test files.
Description check ✅ Passed The description 'Reverts xfails added in #7872' is directly related to the changeset, referencing a specific prior PR that introduced the xfails being removed.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Mar 16, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 0ed0559 into rapidsai:release/26.04 Mar 16, 2026
94 checks passed
@jcrist jcrist deleted the remove-cudf-pandas-xfails branch March 16, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants