fix verify-hardcoded-version issues#7882
fix verify-hardcoded-version issues#7882rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
Conversation
| ^[.]pre-commit-config[.]yaml$| | ||
| ^conda/environments/| | ||
| (^|/)VERSION$| | ||
| (^|/)RAPIDS_BRANCH$| |
There was a problem hiding this comment.
RAPIDS_BRANCH is the relevant one here, but I just copied the entire default config from https://github.com/rapidsai/pre-commit-hooks/blob/21c6bc63c83501a320b7aa8cbb3ca17adb61df2a/.pre-commit-hooks.yaml#L43
Not sure why that didn't just get pulled in directly (exclude: was not overridden here), but this should work just fine.
There was a problem hiding this comment.
IIRC, I changed the upstream exclude: after release and just haven't released it yet (or this repo isn't using that release yet)
There was a problem hiding this comment.
ahhh ok, that'd explain it. Well let's keep this change for now, but we should do a release too.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can generate a title for your PR based on the changes.Add |
| ^[.]pre-commit-config[.]yaml$| | ||
| ^conda/environments/| | ||
| (^|/)VERSION$| | ||
| (^|/)RAPIDS_BRANCH$| |
There was a problem hiding this comment.
IIRC, I changed the upstream exclude: after release and just haven't released it yet (or this repo isn't using that release yet)
|
/merge |
4c7ea21
into
rapidsai:release/26.04
Similar to #7882 Fixes new `verify-hardcoded-version` findings on `main` ```text In file python/cuml/cuml/internals/validation.py💯66: "the feature names of dataframe-like inputs. In cuml 26.06 this " warning: do not hard-code version, read from VERSION file instead In file python/cuml/cuml/internals/validation.py💯66: "the feature names of dataframe-like inputs. In cuml 26.06 this " In file python/cuml/tests/ts_datasets/hourly_earnings_by_industry.csv:102:14: 2014Q1,29.29,26.6,35.07,26.02,29.01,19,17.16,26.57,38.91,40.75,28.84,31.03,34.1 ,29.29 warning: do not hard-code version, read from VERSION file instead In file python/cuml/tests/ts_datasets/hourly_earnings_by_industry.csv:102:14: 2014Q1,29.29,26.6,35.07,26.02,29.01,19,17.16,26.57,38.91,40.75,28.84,31.03,34.1 ,29.29 ```
Fixes this
pre-commiterror that's blocking CI:See rapidsai/pre-commit-hooks#121 for more details.