Skip to content

fix verify-hardcoded-version issues#7882

Merged
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jameslamb:fix/precommit
Mar 12, 2026
Merged

fix verify-hardcoded-version issues#7882
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jameslamb:fix/precommit

Conversation

@jameslamb
Copy link
Copy Markdown
Member

Fixes this pre-commit error that's blocking CI:

verify-hardcoded-version.................................................Failed
- hook id: verify-hardcoded-version
- exit code: 1

In file RAPIDS_BRANCH:1:9:
 release/26.04
warning: do not hard-code version, read from VERSION file instead

In file RAPIDS_BRANCH:1:9:
 release/26.04

See rapidsai/pre-commit-hooks#121 for more details.

@jameslamb jameslamb requested a review from a team as a code owner March 12, 2026 20:35
@jameslamb jameslamb requested a review from msarahan March 12, 2026 20:35
Comment thread .pre-commit-config.yaml
^[.]pre-commit-config[.]yaml$|
^conda/environments/|
(^|/)VERSION$|
(^|/)RAPIDS_BRANCH$|
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RAPIDS_BRANCH is the relevant one here, but I just copied the entire default config from https://github.com/rapidsai/pre-commit-hooks/blob/21c6bc63c83501a320b7aa8cbb3ca17adb61df2a/.pre-commit-hooks.yaml#L43

Not sure why that didn't just get pulled in directly (exclude: was not overridden here), but this should work just fine.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I changed the upstream exclude: after release and just haven't released it yet (or this repo isn't using that release yet)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh ok, that'd explain it. Well let's keep this change for now, but we should do a release too.

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 12, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d3d3aea5-9358-4993-8ad2-47c72c79e6f2

📥 Commits

Reviewing files that changed from the base of the PR and between 35fc9e3 and 6b0442a.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated pre-commit configuration to exclude additional file patterns from version verification checks, reducing false positives during development.

Walkthrough

The .pre-commit-config.yaml file was updated to add an exclude configuration block to the verify-hardcoded-version pre-commit hook, specifying multiple paths and file patterns to be skipped during verification runs.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Added exclude block to verify-hardcoded-version hook with multiple path and file-pattern exclusions to skip hardcoded-version verification for specified files and patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing verify-hardcoded-version issues by adding exclusions to the pre-commit configuration.
Description check ✅ Passed The description is directly related to the changeset, explaining the specific pre-commit hook failure and referencing the relevant issue for context about the fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can generate a title for your PR based on the changes.

Add @coderabbitai placeholder anywhere in the title of your PR and CodeRabbit will replace it with a title based on the changes in the PR. You can change the placeholder by changing the reviews.auto_title_placeholder setting.

Comment thread .pre-commit-config.yaml
^[.]pre-commit-config[.]yaml$|
^conda/environments/|
(^|/)VERSION$|
(^|/)RAPIDS_BRANCH$|
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, I changed the upstream exclude: after release and just haven't released it yet (or this repo isn't using that release yet)

@jcrist
Copy link
Copy Markdown
Member

jcrist commented Mar 12, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 4c7ea21 into rapidsai:release/26.04 Mar 12, 2026
99 of 101 checks passed
jameslamb added a commit that referenced this pull request Mar 13, 2026
Similar to #7882 

Fixes new `verify-hardcoded-version` findings on `main`

```text
In file python/cuml/cuml/internals/validation.py💯66:
             "the feature names of dataframe-like inputs. In cuml 26.06 this "
warning: do not hard-code version, read from VERSION file instead

In file python/cuml/cuml/internals/validation.py💯66:
             "the feature names of dataframe-like inputs. In cuml 26.06 this "

In file python/cuml/tests/ts_datasets/hourly_earnings_by_industry.csv:102:14:
 2014Q1,29.29,26.6,35.07,26.02,29.01,19,17.16,26.57,38.91,40.75,28.84,31.03,34.1
,29.29
warning: do not hard-code version, read from VERSION file instead

In file python/cuml/tests/ts_datasets/hourly_earnings_by_industry.csv:102:14:
 2014Q1,29.29,26.6,35.07,26.02,29.01,19,17.16,26.57,38.91,40.75,28.84,31.03,34.1
,29.29
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants