Skip to content

WIP: wheels CI: write constraints directly to PIP_CONSTRAINT #7853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jameslamb wants to merge 2 commits into from
Closed

WIP: wheels CI: write constraints directly to PIP_CONSTRAINT #7853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94ca788
wheels CI: write constraints directly to PIP_CONSTRAINT
jameslamb Mar 4, 2026
b541294
use fork
jameslamb Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions ci/test_wheel.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@

set -euo pipefail

# TODO(jameslamb): revert before merging
git clone --branch generate-pip-constraints \
https://github.com/rapidsai/gha-tools.git \
/tmp/gha-tools

export PATH="/tmp/gha-tools/tools:${PATH}"

Comment on lines +7 to +13
Copy link
Member Author

@jameslamb jameslamb Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO(jameslamb): revert before merging
git clone --branch generate-pip-constraints \
https://github.com/rapidsai/gha-tools.git \
/tmp/gha-tools
export PATH="/tmp/gha-tools/tools:${PATH}"

source rapids-init-pip

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen "${RAPIDS_CUDA_VERSION}")"
Expand All @@ -14,13 +21,12 @@ mkdir -p "${RAPIDS_TESTS_DIR}"

# generate constraints, the constraints will limit the version of the
# dependencies that can be installed later on when installing the wheel
rapids-generate-pip-constraints test_python ./constraints.txt
rapids-generate-pip-constraints test_python "${PIP_CONSTRAINT}"

# Install just minimal dependencies first
rapids-pip-retry install \
"${LIBCUML_WHEELHOUSE}"/libcuml*.whl \
"${CUML_WHEELHOUSE}"/cuml*.whl \
--constraint ./constraints.txt \
--constraint "${PIP_CONSTRAINT}"

# Try to import cuml with just a minimal install"
Expand All @@ -29,14 +35,13 @@ python -c "import cuml"

# notes:
#
# * echo to expand wildcard before adding `[test,experimental]` requires for pip
# * need to provide --constraint="${PIP_CONSTRAINT}" because that environment variable is
# ignored if any other --constraint are passed via the CLI
# * echo to expand wildcard before adding `[test]` requires for pip
# * just providing --constraint="${PIP_CONSTRAINT}" to be explicit, and because
# that environment variable is ignored if any other --constraint are passed via the CLI
#
rapids-pip-retry install \
"${LIBCUML_WHEELHOUSE}"/libcuml*.whl \
"$(echo "${CUML_WHEELHOUSE}"/cuml*.whl)[test]" \
--constraint ./constraints.txt \
--constraint "${PIP_CONSTRAINT}"

EXITCODE=0
Expand Down
16 changes: 11 additions & 5 deletions ci/test_wheel_dask.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@

set -euo pipefail

# TODO(jameslamb): revert before merging
git clone --branch generate-pip-constraints \
https://github.com/rapidsai/gha-tools.git \
/tmp/gha-tools

export PATH="/tmp/gha-tools/tools:${PATH}"

Comment on lines +7 to +13
Copy link
Member Author

@jameslamb jameslamb Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# TODO(jameslamb): revert before merging
git clone --branch generate-pip-constraints \
https://github.com/rapidsai/gha-tools.git \
/tmp/gha-tools
export PATH="/tmp/gha-tools/tools:${PATH}"

source rapids-init-pip

RAPIDS_PY_CUDA_SUFFIX="$(rapids-wheel-ctk-name-gen "${RAPIDS_CUDA_VERSION}")"
Expand All @@ -14,18 +21,17 @@ mkdir -p "${RAPIDS_TESTS_DIR}"

# generate constraints, the constraints will limit the version of the
# dependencies that can be installed later on when installing the wheel
rapids-generate-pip-constraints test_python ./constraints.txt
rapids-generate-pip-constraints test_python "${PIP_CONSTRAINT}"

# notes:
#
# * echo to expand wildcard before adding `[...]` extras for pip
# * need to provide --constraint="${PIP_CONSTRAINT}" because that environment variable is
# ignored if any other --constraint are passed via the CLI
# * echo to expand wildcard before adding `[...]` requires for pip
# * just providing --constraint="${PIP_CONSTRAINT}" to be explicit, and because
# that environment variable is ignored if any other --constraint are passed via the CLI
#
rapids-pip-retry install \
"${LIBCUML_WHEELHOUSE}"/libcuml*.whl \
"$(echo "${CUML_WHEELHOUSE}"/cuml*.whl)[dask,test,test-dask]" \
--constraint ./constraints.txt \
--constraint "${PIP_CONSTRAINT}"

EXITCODE=0
Expand Down