Skip to content

refactor(limited api): add explicit wheel.py-api to pyproject.toml #7832

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
gforsyth:explicit-wheel-py-api
Feb 25, 2026
Merged

refactor(limited api): add explicit wheel.py-api to pyproject.toml #7832
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
gforsyth:explicit-wheel-py-api

Conversation

@gforsyth
Copy link
Copy Markdown
Contributor

Description

As part of rapidsai/build-planning#42 I added support for building limited API wheels and conda packages.

To enable a RAPIDS-wide bump of the lower-bound of the limited API version we use (currently cp311), the flags that set these options are passed in via environment variables.

This leads us to an issue where local developer builds, either in devcontainers or otherwise, will build without the limited API, unless devs have set an (otherwise unnecessary) environment variable.

So here, I set the py-api version explicitly, so that local builds will always produce limited API wheels and so better reflect what we build and test in CI.

We retain the ability to bump all of RAPIDS to a different cp3xx value because the flag passed in by our scripts overrides the value set in the pyproject.toml. There may be short periods where the flags we are building with and the flags set in pyproject.toml differ, but that should happen infrequently at best.

@gforsyth gforsyth requested a review from a team as a code owner February 25, 2026 17:05
@gforsyth gforsyth requested a review from jameslamb February 25, 2026 17:05
@gforsyth gforsyth added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Feb 25, 2026
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Feb 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2797825 and 60a7cd2.

📒 Files selected for processing (1)
  • python/cuml/pyproject.toml

📝 Walkthrough

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated build configuration to specify Python API version for wheel distribution.

Walkthrough

Adds a single configuration entry wheel.py-api = "cp311" to the [tool.scikit-build] section in the Python CUDA ML project's build configuration, specifying the Python API version for wheel building operations.

Changes

Cohort / File(s) Summary
Build Configuration
python/cuml/pyproject.toml
Added wheel.py-api = "cp311" configuration key under [tool.scikit-build] section to specify Python API version for wheel building.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding an explicit wheel.py-api configuration to pyproject.toml for limited API support.
Description check ✅ Passed The description clearly explains the rationale for the change, relating to limited API wheel building and ensuring local developer builds match CI behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gforsyth
Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot rapids-bot Bot merged commit 8818ad5 into rapidsai:main Feb 25, 2026
94 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants