Fix Dask KMeans performance regression#7819
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Feb 24, 2026
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change updates the default RNG state initialization in KMeansParams to explicitly specify the GenPhilox generator type in addition to the seed value. The copyright year header is also incremented from 2025 to 2026. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
divyegala
approved these changes
Feb 20, 2026
aamijar
approved these changes
Feb 23, 2026
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7749
The KMeans parameter struct on cuML side used to be calloc'ed, and is now constructed on stack. Because of this, Dask Kmeans used to use
raft::random::GeneratorType::GenPhilox(value of 0) as its random number generator type and now usesraft::random::GeneratorType::GenPC(constructor default of 1). This somehow causes the KMeans initialization or convergence steps to be of lower quality. Converges in ~40 steps instead of 2.This PR fixes the issue by setting
raft::random::GeneratorType::GenPhiloxas the default inside of the cuML parameter struct default values.