Mark two tests as flaky#7787
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo xfail test entries for calibration multiclass tests are moved from their original location to a newly introduced LinearSVM block in the xfail list configuration. The block sets strict to false and groups both tests under a LinearSVM reason category. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@betatim Apparently I was not seeing ghosts... |
|
I restarted the failed job now that cudf fixed the bug they introduced which was causing the failure. Let's see what happens now |
|
/merge |
Moved from strict xfail to flaky (`strict: false`) in `xfail-list.yaml`: - `test_calibration_multiclass[1-False-isotonic]` - `test_calibration_multiclass[1-False-sigmoid]` Authors: - Simon Adorf (https://github.com/csadorf) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#7787
Moved from strict xfail to flaky (
strict: false) inxfail-list.yaml:test_calibration_multiclass[1-False-isotonic]test_calibration_multiclass[1-False-sigmoid]