Add cuml.accel support for Pipeline#7782
Closed
csadorf wants to merge 24 commits intorapidsai:mainfrom
Closed
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
added
feature request
csadorf
changed the title
csadorf
force-pushed
the
add-cuml.accel-support-for-pipeline
branch
from
6b992db to
29007e9
Compare
Contributor
Author
|
/ok to test 29007e9 |
csadorf
commented
Feb 18, 2026
Contributor
Author
There was a problem hiding this comment.
We'll want to revert these changes before merge and roll the them into their own PR.
csadorf
commented
Feb 18, 2026
| filterwarnings = | ||
| # Error if the xfail list contains unknown entries | ||
| error::cuml.accel.pytest_plugin.UnmatchedXfailTests | ||
| ; error::cuml.accel.pytest_plugin.UnmatchedXfailTests |
Contributor
Author
There was a problem hiding this comment.
revert before merge
Member
|
I've pushed up an alternative (and I believe simpler implementation) here: #7835. |
rapids-bot Bot
pushed a commit
that referenced
this pull request
Mar 3, 2026
This PR adds an optimization for `Pipeline`s when running under `cuml.accel`. In cases where the tail end of operations performed by a pipeline are all accelerated, we can avoid intermediate host<->device transfers and pass the intermediates on device. For example, a pipeline of `unaccelerated -> unaccelerated -> accelerated -> accelerated` wouldn't need to convert the intermediate result back to numpy between steps 3 and 4 and could pass that on device. A pipeline of `unaccelerated -> accelerated -> unaccelerated -> accelerated` though would keep passing intermediates on host since there's not a contiguous block of accelerated estimators. The actual implementation of this is roughly ~100 lines. The remainder is tests, as well as a refactor to better distinguish between patches (mutate the original module) and overrides (overlay over the original module). Fixes #7778. Supersedes #7782. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Simon Adorf (https://github.com/csadorf) URL: #7835
Member
|
Superseded by #7835. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft implementation for cuml.accel support for Pipeline
Based on #7766
Closes #7778