Skip to content

Partially revert #7715.#7773

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
csadorf:revert-7715
Feb 6, 2026
Merged

Partially revert #7715.#7773
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
csadorf:revert-7715

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Feb 6, 2026

@csadorf csadorf requested a review from a team as a code owner February 6, 2026 18:17
@csadorf csadorf requested a review from jameslamb February 6, 2026 18:17
@github-actions github-actions Bot added the ci label Feb 6, 2026
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed ci labels Feb 6, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 6, 2026

📝 Walkthrough

Walkthrough

The BERTopic integration test script was modified to remove an explicit installation of the requests package following BERTopic setup. All other test steps, including the two-step cuML wheel installation and BERTopic configuration, remain unchanged.

Changes

Cohort / File(s) Summary
Dependency Installation
ci/test_wheel_integrations.sh
Removed explicit requests package installation line after BERTopic setup step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Partially revert #7715' directly matches the changeset, which removes an explicit requests package installation line from the BERTopic integration test script, undoing a previous change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description mentions a specific upstream fix (sentence-transformers#3617) that directly relates to the changeset, which removes an explicit requests package installation from the BERTopic integration test.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna brag for a second and say.... look at all that unnecessary CI being skipped now because of #7738 😁 😁 😁

Image

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Feb 6, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 2a2b1c5 into rapidsai:main Feb 6, 2026
79 checks passed
@csadorf csadorf deleted the revert-7715 branch February 6, 2026 19:33
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants