Skip to content

CI Use ipython 7.34.0 in "oldest" version CI#7743

Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
betatim:add-ipython-7-back
Feb 4, 2026
Merged

CI Use ipython 7.34.0 in "oldest" version CI#7743
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
betatim:add-ipython-7-back

Conversation

@betatim
Copy link
Copy Markdown
Member

@betatim betatim commented Jan 30, 2026

Google Colab uses ipython 7.34.0 with Python 3.12 in their latest runtime version. As we want to support colab we should keep testing with this old version of iPython. iPython 7.x itself isn't incompatible with Python 3.11, but conda-forge does not provide packages for iPython 7 and Python 3.11.

The result of this is that we have to do a bit of gymnastics to use iPython 8 for conda based workflows and iPython 7 for pip based workflows.

Let's see what the CI says to this.

Follow up to #7737

@betatim betatim requested a review from a team as a code owner January 30, 2026 07:56
@betatim betatim requested a review from jameslamb January 30, 2026 07:56
@betatim betatim added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 30, 2026
@betatim betatim force-pushed the add-ipython-7-back branch from c4c36be to 6654264 Compare January 30, 2026 10:11
@github-actions github-actions Bot added conda conda issue Cython / Python Cython or Python issue labels Feb 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 3, 2026

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated minimum ipython dependency version constraints to improve compatibility and flexibility with existing environments.

Walkthrough

The PR updates ipython minimum version constraints from >=8.4.0 to >=7.32.0 across multiple configuration files. Additionally, dependencies.yaml is restructured to handle ipython versions separately for conda and pip-based dependency matrices, with conda using ipython=8 and pip using ipython==7.34.0 for the oldest dependency path.

Changes

Cohort / File(s) Summary
Conda Environment Files
conda/environments/all_cuda-129_arch-aarch64.yaml, conda/environments/all_cuda-129_arch-x86_64.yaml, conda/environments/all_cuda-131_arch-aarch64.yaml, conda/environments/all_cuda-131_arch-x86_64.yaml
Lowered ipython minimum version constraint from >=8.4.0 to >=7.32.0 across all four environment configuration files.
Dependency Matrix Configuration
dependencies.yaml
Restructured ipython version handling to split conda and pip dependency paths in the oldest matrix: conda uses ipython=8, pip/pyproject uses ipython==7.34.0. Updated global ipython constraint from >=8.4.0 to >=7.32.0. Added explanatory comments regarding Python 3.11+ compatibility across package managers.
Test Dependencies
python/cuml/pyproject.toml
Reduced ipython test dependency constraint from >=8.4.0 to >=7.32.0 in the optional-dependencies test section.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly references the main change: updating to use ipython 7.34.0 in the oldest version CI, which is the core objective of this pull request.
Description check ✅ Passed The description clearly explains the rationale for the changes: supporting Google Colab's ipython 7.34.0, handling conda-forge constraints, and implementing different versions for conda vs pip workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Important

Action Needed: IP Allowlist Update

If your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:

  • 136.113.208.247/32 (new)
  • 34.170.211.100/32
  • 35.222.179.152/32

Failure to add the new IP will result in interrupted reviews.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Feb 3, 2026

Let's see what the CI says to this.

Seems to be working!

@betatim
Copy link
Copy Markdown
Member Author

betatim commented Feb 4, 2026

The "oldest" wheel test job used ipython 7.34.0. Good to go for me

@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Feb 4, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 72a5214 into rapidsai:main Feb 4, 2026
112 checks passed
@betatim betatim deleted the add-ipython-7-back branch February 5, 2026 08:11
dantegd added a commit to dantegd/cuml that referenced this pull request Feb 17, 2026
Google Colab uses ipython 7.34.0 with Python 3.12 in their latest runtime version. As we want to support colab we should keep testing with this old version of iPython. iPython 7.x itself isn't incompatible with Python 3.11, but conda-forge does not provide packages for iPython 7 and Python 3.11.

The result of this is that we have to do a bit of gymnastics to use iPython 8 for conda based workflows and iPython 7 for pip based workflows.

Let's see what the CI says to this.

Follow up to rapidsai#7737

Authors:
  - Tim Head (https://github.com/betatim)

Approvers:
  - James Lamb (https://github.com/jameslamb)

URL: rapidsai#7743
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants