CI Use ipython 7.34.0 in "oldest" version CI#7743
CI Use ipython 7.34.0 in "oldest" version CI#7743rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
Conversation
c4c36be to
6654264
Compare
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe PR updates ipython minimum version constraints from >=8.4.0 to >=7.32.0 across multiple configuration files. Additionally, dependencies.yaml is restructured to handle ipython versions separately for conda and pip-based dependency matrices, with conda using ipython=8 and pip using ipython==7.34.0 for the oldest dependency path. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Failure to add the new IP will result in interrupted reviews. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Seems to be working! |
|
The "oldest" wheel test job used ipython 7.34.0. Good to go for me |
|
/merge |
Google Colab uses ipython 7.34.0 with Python 3.12 in their latest runtime version. As we want to support colab we should keep testing with this old version of iPython. iPython 7.x itself isn't incompatible with Python 3.11, but conda-forge does not provide packages for iPython 7 and Python 3.11. The result of this is that we have to do a bit of gymnastics to use iPython 8 for conda based workflows and iPython 7 for pip based workflows. Let's see what the CI says to this. Follow up to rapidsai#7737 Authors: - Tim Head (https://github.com/betatim) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#7743
Google Colab uses ipython 7.34.0 with Python 3.12 in their latest runtime version. As we want to support colab we should keep testing with this old version of iPython. iPython 7.x itself isn't incompatible with Python 3.11, but conda-forge does not provide packages for iPython 7 and Python 3.11.
The result of this is that we have to do a bit of gymnastics to use iPython 8 for conda based workflows and iPython 7 for pip based workflows.
Let's see what the CI says to this.
Follow up to #7737