Use verify-hardcoded-version pre-commit hook#7726
Use verify-hardcoded-version pre-commit hook#7726rapids-bot[bot] merged 10 commits intorapidsai:mainfrom
Conversation
jameslamb
left a comment
There was a problem hiding this comment.
Left one suggestion.
I also think the cases that needed # rapids-pre-commit-hooks: disable comments here are common enough that it would be worth adding more heuristics (expanding on rapidsai/pre-commit-hooks#102) to exclude these strings (case insensitive):
- "in {version}"
- "since {version}"
- "after {version}"
I can't think of any situation where those would exist in a use-case where we'd want the output of $(cat VERSION) for {version} instead of a specific hard-coded version.
Addressed in rapidsai/pre-commit-hooks#108 |
jameslamb
left a comment
There was a problem hiding this comment.
Approving so you can get this merged and the repo doesn't pick up more hardcoded versions, but left a suggestion on expanding the heuristics.
|
/merge |
Ops-Bot-Merge-Barrier: true Authors: - Kyle Edwards (https://github.com/KyleFromNVIDIA) Approvers: - James Lamb (https://github.com/jameslamb) URL: rapidsai#7726
Ops-Bot-Merge-Barrier: true