CI: Test CuPy nightlies#7695
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
csadorf
added
improvement
csadorf
force-pushed
the
ci/test-cupy-nightlies
branch
from
d2b6c47 to
059c04a
Compare
github-actions
Bot
added
conda
csadorf
force-pushed
the
ci/test-cupy-nightlies
branch
from
059c04a to
2c03b46
Compare
|
/ok to test 2c03b46 |
csadorf
force-pushed
the
ci/test-cupy-nightlies
branch
from
2c03b46 to
740ae9a
Compare
|
/ok to test 740ae9a |
|
/ok to test 4dbdcb2 |
csadorf
force-pushed
the
ci/test-cupy-nightlies
branch
from
4dbdcb2 to
2d43594
Compare
|
/ok to test 2d43594 |
|
I confirmed that all nightly-dependency tests pass for 2d43594 in https://github.com/rapidsai/cuml/actions/runs/21295022206?pr=7695 , except the py310 job which failed, because scikit-learn requires Python>=3.11 . |
| [-0.8817671 -0.84549576 0.1845096 0.02556021]] | ||
|
|
||
| >>> print(y) | ||
| >>> print(y) # doctest: +SKIP |
There was a problem hiding this comment.
curious, why do we need this skip now?
There was a problem hiding this comment.
The dataset generated by make_classification is not the same between cupy <14rc and cupy >=14rc even with the same random seed. That was previously already the case for the floating point values in X, and now is also the case for the integer y dataset. I am not sure whether that is expected, but it is certainly not surprising to me that there would be no random data stability between major versions.
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Left 2 very very minor suggestions, otherwise looks good. Cool use of this CI job!
| - cupy-cuda12x>=13.6.0a0 | ||
| - matrix: | ||
| cuda: "13.*" | ||
| dependencies: "nightly" | ||
| packages: | ||
| - cupy-cuda13x>=13.6.0a0 | ||
| - matrix: | ||
| dependencies: "nightly" | ||
| packages: | ||
| - cupy-cuda13x>=13.6.0a0 |
There was a problem hiding this comment.
| - cupy-cuda12x>=13.6.0a0 | |
| - matrix: | |
| cuda: "13.*" | |
| dependencies: "nightly" | |
| packages: | |
| - cupy-cuda13x>=13.6.0a0 | |
| - matrix: | |
| dependencies: "nightly" | |
| packages: | |
| - cupy-cuda13x>=13.6.0a0 | |
| - cupy-cuda12x>=14.0.0a0 | |
| - matrix: | |
| cuda: "13.*" | |
| dependencies: "nightly" | |
| packages: | |
| - &cupy_cu13_nightly cupy-cuda13x>=14.0.0a0 | |
| - matrix: | |
| dependencies: "nightly" | |
| packages: | |
| - *cupy_cu13_nightly |
If you want to be sure this is pulling at least 14.0 nightlies, I think this floor should be moved up.
Encoding the fallback as "whatever we use for CUDA 13" with YAML anchors is also helpful to clarify the intent.
There was a problem hiding this comment.
I believe this is working as expected, so I'm going to leave the configuration as-is to reduce churn. We can improve this if we need to make other changes to this job either in this PR or in a follow-up.
|
/merge |
4 participants
Add CuPy nightly testing to the
wheel-tests-cuml-nightly-dependencies-versionsjob.Adjusted three tests that required stability of the random generator which can probably not be reasonably assumed across major versions.