Skip to content

Handle new sklearn LARS error message in test_typeerror_input#7694

Merged
rapids-bot[bot] merged 1 commit intorapidsai:release/26.02from
csadorf:fix-kernel-shap-test-sklearn-error
Jan 16, 2026
Merged

Handle new sklearn LARS error message in test_typeerror_input#7694
rapids-bot[bot] merged 1 commit intorapidsai:release/26.02from
csadorf:fix-kernel-shap-test-sklearn-error

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Jan 16, 2026

The sklearn LARS path solver now raises a different error message ('dimension must be fixed to') instead of the previously expected 'operands could not be broadcast together'. Both are likely manifestations of the same underlying bug (scikit-learn/scikit-learn#9603).

Update the test to catch both error patterns and mark them as xfail.

Likely related to #6971 .

@csadorf csadorf requested a review from a team as a code owner January 16, 2026 16:24
@csadorf csadorf requested a review from betatim January 16, 2026 16:24
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jan 16, 2026
@csadorf csadorf changed the base branch from main to release/26.02 January 16, 2026 16:24
@csadorf csadorf requested review from a team as code owners January 16, 2026 16:24
@csadorf csadorf requested a review from AyodeAwe January 16, 2026 16:24
The sklearn LARS path solver now raises a different error message
('dimension must be fixed to') instead of the previously expected
'operands could not be broadcast together'. Both are manifestations
of the same underlying bug (scikit-learn#9603).

Update the test to catch both error patterns and mark them as xfail.
@csadorf csadorf force-pushed the fix-kernel-shap-test-sklearn-error branch from a2de6c6 to 9edf2a5 Compare January 16, 2026 16:25
@csadorf csadorf removed request for a team and AyodeAwe January 16, 2026 16:25
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Jan 16, 2026
Copy link
Copy Markdown
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jan 16, 2026

/merge

@rapids-bot rapids-bot Bot merged commit d9c9353 into rapidsai:release/26.02 Jan 16, 2026
219 of 223 checks passed
@csadorf csadorf deleted the fix-kernel-shap-test-sklearn-error branch January 16, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants