Fix int64 Spectral Embedding#7689
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Jan 16, 2026
Merged
Conversation
aamijar
added
non-breaking
dantegd
requested changes
Jan 16, 2026
Member
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
PR is correct and well done. The main question in the review is whether spectral_clustering should receive the same treatment for API consistency, or if there's a deliberate reason to keep them different.
Member
Author
Yes, that is in the works. There are some cuvs side changes that need to go in first though. Tracking that here rapidsai/cuvs#1484. For more API consistency we may also change the output produced by spectral embedding to have int64 as well. That will require this rapidsai/raft#2925. |
dantegd
approved these changes
Jan 16, 2026
Member
|
/merge |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to edit the coo wrapper api (rows, cols, vals) to use int64 for the indexes and also the python nnz value.