Remove unused QR decomposition MG code#7687
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Jan 16, 2026
Merged
Conversation
Contributor
Author
|
Seems like this is technically a breaking change (despite the code being unused in python), so I will label as such. |
JohnZed
added
improvement
Member
|
Need to do ok to test because of the first commit |
Member
|
/ok to test b568c0c |
Contributor
Author
|
/ok to test 4a9e50d |
dantegd
approved these changes
Jan 16, 2026
Member
dantegd
left a comment
dantegd
left a comment
There was a problem hiding this comment.
Nothing better than removing code :)
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in Issue #7685 - this code appears to be buggy for non-tiny matrices. But it has also never been exposed to Python, so it is unused except for a small test. Per @jcrist and @csadorf 's comments on the issue, it just makes sense to remove this code. (Note that this PR is heavily AI-assisted.)
Closes #7685