Support older IPython versions for cuml.accel magics#7675
Merged
rapids-bot[bot] merged 6 commits intorapidsai:release/26.02from Jan 16, 2026
Merged
Support older IPython versions for cuml.accel magics#7675rapids-bot[bot] merged 6 commits intorapidsai:release/26.02from
cuml.accel magics#7675rapids-bot[bot] merged 6 commits intorapidsai:release/26.02from
Conversation
github-actions
Bot
added
conda
jameslamb
approved these changes
Jan 13, 2026
Member
jameslamb
left a comment
jameslamb
left a comment
There was a problem hiding this comment.
Makes sense to me based on the PR description, thank you.
csadorf
approved these changes
Jan 13, 2026
Contributor
Can you have a look, please? |
This guards our import of `output_can_be_silenced` (added in IPython 8.10.0), allowing us to support older IPython versions. This is mainly relevant to some cloudproviders running on very old IPython.
This adds IPython as a test dependency - previously we were erroneously not running these tests in CI. Also splits out the version used in the CI matrix so we can test against older IPython to ensure everything works.
Easier to skip the test than modify it to check for different output on very old IPython versions.
jcrist
force-pushed
the
support-old-ipython
branch
from
1c17934 to
95dec47
Compare
Member
Author
|
7.34.0 isn't on conda-forge for unknown reasons, I've adjusted the lower bound to 7.32.0 instead. Also had a slight test fixup to work across ipython versions - should be good-to-go now. |
Member
Author
|
/merge |
rapids-bot
Bot
merged commit 8048ffc
into
rapidsai:release/26.02
115 of 117 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for older IPython versions to
cuml.accel's IPython magics. Previously we were using a decorator added in IPython 8.10 (released Feb 2023)This also adds IPython as a test dependency - previously we were erroneously not running these tests in CI. We test against IPython versions >= 7.34.0 (released May 2022), which is the oldest version used by some cloud providers, but with this change likely support significantly older versions as well. Since it's not a runtime dependency except for the magics (which by definition will have IPython installed), I think adding a test dep of
ipython >= 7.34.0is sufficient. We also now branch out IPython versions in our test matrix, so some builds will test on the older versions to ensure they work.