Skip to content

Use saga solver in test_logistic_regression test function.#7670

Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
csadorf:fix/issue-7669
Jan 14, 2026
Merged

Use saga solver in test_logistic_regression test function.#7670
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
csadorf:fix/issue-7669

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Jan 13, 2026

Fixes #7669 .

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jan 13, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Cython / Python Cython or Python issue ci labels Jan 13, 2026
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change DO NOT MERGE Hold off on merging; see PR for details and removed Cython / Python Cython or Python issue ci labels Jan 13, 2026
@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jan 13, 2026

/ok to test 49cfebe

@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Jan 13, 2026
@csadorf csadorf marked this pull request as ready for review January 13, 2026 16:48
@csadorf csadorf requested a review from a team as a code owner January 13, 2026 16:48
@csadorf csadorf requested a review from jcrist January 13, 2026 16:48
@csadorf csadorf removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 13, 2026
Copy link
Copy Markdown
Member

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why this is showing up now?

@jcrist
Copy link
Copy Markdown
Member

jcrist commented Jan 13, 2026

Failures are due to #7671

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jan 13, 2026

Any idea why this is showing up now?

This is a hypothesis test. That parameter combination was not encountered previously.

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Jan 14, 2026

/merge

@rapids-bot rapids-bot Bot merged commit 9038e19 into rapidsai:main Jan 14, 2026
110 checks passed
@csadorf csadorf deleted the fix/issue-7669 branch January 14, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] test_logistic_regression fails with sklearn solver/penalty mismatch

3 participants