[DOC] Add missing parameters to UMAP and NearestNeighbors docstrings

[silasmue]

Related issue: Issue #6211

I added the requested documentation for UMAP and Nearest Neighbor.

UMAP: Added documentation for the parameters target_n_neighbors, target_weight, target_metric. Except for some typos I took the documentation from umap-learn.

Nearest Neighbor: I added the supported metrics as requested in the #6211 issue, and double checked them with the code if they are supported.

This is my first contribution, if everything is okay I would look into another issue.

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[silasmue]

I think the DOC label is missing, I can not change the label myself.

[silasmue]

Thanks for adding the doc label. I think the last step to run the pipeline successful is to mark the change as non-breaking because it's just an improvement in the documentation.

[csadorf]

Please rebase this PR and target the main branch.

[jinsolp]

Thank you for your work! Added a minor suggestion.

[jinsolp]

Suggested change

	(e.g. for a regression problem) then metric of 'l1' or 'l2' is
	probably more appropriate.
	(e.g. for a regression problem) then metric of 'euclidean' or 'l2' is
	probably more appropriate.

Suggesting small fix because our supported target metrics are defined as below;

_TARGET_METRICS = {
    "euclidean": lib.MetricType.EUCLIDEAN,
    "l2": lib.MetricType.EUCLIDEAN,
    "categorical": lib.MetricType.CATEGORICAL,
}

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[csadorf]

Please rebase this PR and target the main branch.

I've rebased the branch and updated the PR target branch.

[csadorf]

/ok to test c9caf7f

[csadorf]

Is there something missing. I would search for another small issue I could solve now, if there are any changes, improvements or suggestions just let me know.

No, this should be good to go. We just need to get a good CI run.

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • UMAP adds three user-facing tuning options for targeted embeddings: target_n_neighbors, target_weight, and target_metric, enabling finer control over neighborhood size, influence, and similarity handling.

• Documentation

  • Nearest neighbors documentation expanded with a comprehensive list of supported distance metrics and clearer compatibility notes for different algorithms and input types.

Walkthrough

UMAP gains three public parameters—target_n_neighbors, target_metric, and target_weight—added to the constructor, class parameter listing, and wired through init_params, _params_from_cpu, and _params_to_cpu. NearestNeighbors docstring expanded to list additional supported metrics and clarify algorithm/sparse-input compatibility.

Changes

Cohort / File(s)	Summary
UMAP Parameter Additions python/cuml/cuml/manifold/umap/umap.pyx	Introduced target_n_neighbors, target_metric, and target_weight in UMAP.__init__, added them to _get_param_names(), and propagated through init_params, _params_from_cpu, and _params_to_cpu for parameter mapping and (de)serialization. Review wiring in init/param conversion paths.
NearestNeighbors Metric Documentation python/cuml/cuml/neighbors/nearest_neighbors.pyx	Expanded metric parameter docstring to enumerate many supported metrics (l1, manhattan, euclidean, sqeuclidean, lp, linf, cosine, jaccard, hellinger, haversine, etc.) and updated per-algorithm and sparse-input compatibility notes. No logic changes; review doc accuracy and wording.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: adding missing parameter documentation to UMAP and NearestNeighbors docstrings.
Description check	✅ Passed	The description clearly relates to the changeset, explaining the documentation additions for UMAP parameters and NearestNeighbors metrics with references to the related issue.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@python/cuml/cuml/neighbors/nearest_neighbors.pyx`:
- Around line 475-488: The docstring for metric in nearest_neighbors.pyx has a
missing opening quote before correlation in the metric list causing a mismatched
quote; update the metric string list (in the nearest_neighbors.pyx docstring
block where "metric : string..." is defined) to add the missing leading quote so
that 'correlation' is properly quoted and the sentence reads "'jensenshannon',
'cosine', 'braycurtis', 'jaccard', 'hellinger', 'correlation', 'inner_product'."

[csadorf]

/ok to test cce3ed2

[silasmue]

@csadorf okay nice. I will take a closer look on the weekend if the CI is not working until then.

[csadorf]

/ok to test 0fc5965

[csadorf]

/ok to test 6ed6b51

[csadorf]

/merge