Attempt to find cmake-format-rapids-cmake.json in cpp/latest#7626
Merged
rapids-bot[bot] merged 3 commits intorapidsai:mainfrom Dec 18, 2025
Merged
Attempt to find cmake-format-rapids-cmake.json in cpp/latest#7626rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
cmake-format-rapids-cmake.json in cpp/latest#7626rapids-bot[bot] merged 3 commits intorapidsai:mainfrom
Conversation
divyegala
added
improvement
bdice
requested changes
Dec 17, 2025
Contributor
There was a problem hiding this comment.
Let's match cudf's logic. This should work for cuML too: https://github.com/rapidsai/cudf/blob/main/cpp/scripts/run-cmake-format.sh#L46-L50
Maybe just copy-paste the latest version of that script into cuML and replace s/cudf/cuml/g.
divyegala
changed the title
cmake-format-rapids-cmake.json if not foundcmake-format-rapids-cmake.json in cpp/latest
bdice
approved these changes
Dec 17, 2025
Member
Author
|
/merge |
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
…idsai#7626) This always is an issue otherwise when committing from devcontainers. Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Bradley Dice (https://github.com/bdice) URL: rapidsai#7626
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This always is an issue otherwise when committing from devcontainers.