Skip to content

Forward cuml.accel logging to subprocesses#7602

Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
jcrist:cuml-accel-logging-fixups
Dec 12, 2025
Merged

Forward cuml.accel logging to subprocesses#7602
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom
jcrist:cuml-accel-logging-fixups

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Dec 12, 2025

This:

  • Adds a new CUML_ACCEL_LOG_LEVEL environment variable for configuring the level of the cuml.accel logger. This log level will be used if a level isn't explicitly configured via other means (cuml.accel.install or -v in the CLI).
  • Uses the CUML_ACCEL_LOG_LEVEL environment variable to forward logging configuration on to subprocesses by default. Fixes [FEA] Propagate cuml.accel's -v flag to subprocesses #7572.
  • Also updates the log handler to flush on every write, avoiding delays in logs appearing. Thanks to @betatim for reporting this issue.

Fixes #7572

This adds a new way to configure logging for `cuml.accel`, and also uses
it to forward logging configuration to subprocesses.
@jcrist jcrist self-assigned this Dec 12, 2025
@jcrist jcrist requested a review from a team as a code owner December 12, 2025 16:20
@jcrist jcrist requested a review from csadorf December 12, 2025 16:20
@jcrist jcrist added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change cuml-accel Issues related to cuml.accel labels Dec 12, 2025
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Dec 12, 2025
@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Dec 12, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 778293f into rapidsai:main Dec 12, 2025
191 of 196 checks passed
@jcrist jcrist deleted the cuml-accel-logging-fixups branch December 12, 2025 22:18
mani-builds pushed a commit to mani-builds/cuml that referenced this pull request Jan 11, 2026
This:
- Adds a new `CUML_ACCEL_LOG_LEVEL` environment variable for configuring the level of the `cuml.accel` logger. This log level will be used if a level isn't explicitly configured via other means (`cuml.accel.install` or `-v` in the CLI).
- Uses the `CUML_ACCEL_LOG_LEVEL` environment variable to forward logging configuration on to subprocesses by default. Fixes rapidsai#7572.
- Also updates the log handler to flush on every write, avoiding delays in logs appearing. Thanks to @betatim for reporting this issue.

Fixes rapidsai#7572

Authors:
  - Jim Crist-Harif (https://github.com/jcrist)

Approvers:
  - Simon Adorf (https://github.com/csadorf)

URL: rapidsai#7602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuml-accel Issues related to cuml.accel Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Propagate cuml.accel's -v flag to subprocesses

3 participants