Skip to content

UMAP fix int32 overflow causing illegal mem access #7587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 5 commits into from
Dec 11, 2025
Merged

UMAP fix int32 overflow causing illegal mem access #7587

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3c3870
umap-fix-int32-illegal-mem-access
aamijar Dec 10, 2025
232961a
Merge branch 'main' into umap-fix-int32-illegal-mem-access
aamijar Dec 10, 2025
4a6f381
use size_t
aamijar Dec 10, 2025
eec4595
Merge branch 'main' into umap-fix-int32-illegal-mem-access
aamijar Dec 10, 2025
490c570
cast to size_t
aamijar Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cpp/src/umap/simpl_set_embed/optimize_batch_kernel.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ CUML_KERNEL void optimize_batch_kernel_reg(T const* head_embedding,
T nsr_inv,
T rounding)
{
nnz_t row = (blockIdx.x * static_cast<nnz_t>(TPB_X)) + threadIdx.x;
nnz_t skip_size = blockDim.x * gridDim.x;
size_t row = (static_cast<size_t>(blockIdx.x) * static_cast<size_t>(TPB_X)) + threadIdx.x;
size_t skip_size = static_cast<size_t>(blockDim.x) * gridDim.x;

T current_reg[n_components], other_reg[n_components], grads[n_components];
while (row < nnz) {
Expand Down Expand Up @@ -231,8 +231,8 @@ CUML_KERNEL void optimize_batch_kernel(T const* head_embedding,
T rounding)
{
extern __shared__ T embedding_shared_mem_updates[];
nnz_t row = (blockIdx.x * static_cast<nnz_t>(TPB_X)) + threadIdx.x;
nnz_t skip_size = blockDim.x * gridDim.x;
size_t row = (static_cast<size_t>(blockIdx.x) * static_cast<size_t>(TPB_X)) + threadIdx.x;
size_t skip_size = static_cast<size_t>(blockDim.x) * gridDim.x;

while (row < nnz) {
auto _epoch_of_next_sample = epoch_of_next_sample[row];
Expand Down
Loading