Skip to content

UMAP with int64_t spectral initialization#7586

Merged
rapids-bot[bot] merged 12 commits intorapidsai:mainfrom
aamijar:spectral-embedding-nnz
Jan 15, 2026
Merged

UMAP with int64_t spectral initialization#7586
rapids-bot[bot] merged 12 commits intorapidsai:mainfrom
aamijar:spectral-embedding-nnz

Conversation

@aamijar
Copy link
Copy Markdown
Member

@aamijar aamijar commented Dec 10, 2025

Resolves #7225, Resolves #6910.
Depends on rapidsai/cuvs#1628

This PR pulls in the int64_t support from cuvs to the spectral embedding cuml cpp api. This api is used during UMAP spectral initialization.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Dec 10, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@aamijar aamijar added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Dec 10, 2025
@aamijar aamijar changed the title UMAP with int64_t spectral initialization UMAP with int64_t spectral initialization Dec 10, 2025
@aamijar aamijar marked this pull request as ready for review January 7, 2026 15:51
@aamijar aamijar requested a review from a team as a code owner January 7, 2026 15:51
@aamijar aamijar requested review from hcho3 and jcrist January 7, 2026 15:51
Copy link
Copy Markdown
Contributor

@jinsolp jinsolp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But, aside from UMAP, wouldn't we want to make the change for the SpectralEmbedding estimator as well over here?

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Jan 10, 2026

Hi @viclafargue, I've updated the PR to use int64_t only and removed the int apis from cuml

Copy link
Copy Markdown
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@aamijar
Copy link
Copy Markdown
Member Author

aamijar commented Jan 15, 2026

/merge

@rapids-bot rapids-bot Bot merged commit d9ae57d into rapidsai:main Jan 15, 2026
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algo: spectral-embedding algo: umap CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UMAP spectral initialization with int64_t nnz types. [BUG] CUDA_ERROR_ILLEGAL_ADDRESS issue with cuML UMAP

6 participants