Revert precomputed kNN on CPU for UMAP#7576
Merged
rockhowse merged 1 commit intorapidsai:release/25.12from Dec 9, 2025
Merged
Conversation
jinsolp
added
bug
Contributor
Author
|
Reopen this issue if this PR is merged: #7143 |
aamijar
reviewed
Dec 9, 2025
Member
aamijar
left a comment
aamijar
left a comment
There was a problem hiding this comment.
Does sparsefuncs.py need to be reverted too?
https://github.com/rapidsai/cuml/pull/7481/files#diff-e123694943b2c128462c15c03e507e27026213a63d244100e8190349c26589f9R269
Contributor
Author
|
@aamijar No that just exposes an option and will still work as before because the default is |
aamijar
approved these changes
Dec 9, 2025
divyegala
approved these changes
Dec 9, 2025
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
Admin merging per build-eng request Reverting this PR: rapidsai#7481 because it needs further testing on pointer residency on HMM-configure machines. Related issue: rapidsai#7540
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverting this PR: #7481 because it needs further testing on pointer residency on HMM-configure machines.
Related issue: #7540