Bypass data allocation to GPU given precomputed knn in UMAP#7566
Merged
rapids-bot[bot] merged 8 commits intorapidsai:mainfrom Dec 17, 2025
Merged
Bypass data allocation to GPU given precomputed knn in UMAP#7566rapids-bot[bot] merged 8 commits intorapidsai:mainfrom
rapids-bot[bot] merged 8 commits intorapidsai:mainfrom
Conversation
jinsolp
changed the title
jcrist
reviewed
Dec 4, 2025
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Small nit, otherwise looks good to me!
For testing, do we have tests for passing X on both host and device when using a precomputed knn? If not, can we add one just to ensure full coverage here?
Co-authored-by: Jim Crist-Harif <jcristharif@gmail.com>
jinsolp
force-pushed
the
bypass-data-gpu-alloc-umap
branch
from
447b15b to
35fc0a3
Compare
Contributor
Author
|
thanks @jcrist , added as part of an existing test! |
Contributor
Author
|
@jcrist this is ready for another round of reviews 🙂 |
jcrist
approved these changes
Dec 17, 2025
Member
|
/merge |
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
…#7566) Closes rapidsai#7132 This PR ensures that we don't default to copying data to device memory if precomputed knn graph is given. Authors: - Jinsol Park (https://github.com/jinsolp) Approvers: - Jim Crist-Harif (https://github.com/jcrist) URL: rapidsai#7566
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7132
This PR ensures that we don't default to copying data to device memory if precomputed knn graph is given.