A few small fixes for multi-gpu PCA/TruncatedSVD#7560
Merged
rapids-bot[bot] merged 2 commits intorapidsai:release/25.12from Dec 3, 2025
Merged
A few small fixes for multi-gpu PCA/TruncatedSVD#7560rapids-bot[bot] merged 2 commits intorapidsai:release/25.12from
PCA/TruncatedSVD#7560rapids-bot[bot] merged 2 commits intorapidsai:release/25.12from
Conversation
jcrist
added
the
Dask / cuml.dask
jcrist
changed the title
PCA/TruncatedSVD`PCA/TruncatedSVD
csadorf
approved these changes
Dec 3, 2025
Member
Author
|
/merge |
rapids-bot
Bot
merged commit ebb8e80
into
rapidsai:release/25.12
218 of 220 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cumlbehavior to be the same regardless of sklearn version - the only thing we branch on is the testing where we don't assert sign matches for sklearn < 1.5 (this matches the single-gpu testing strategy as well).signFlipComponents. The multi-gpu implementation makes use of multiple streams, but before only the first stream was passed tosignFlipComponents(without any sync beforehand) leading to potential stream ordering issues. It's hard to prove a negative, but with this change I can no longer reproduce an issue reported inrapids_singlecell. A similar fix isn't needed forTruncatedSVDsince that implementation only uses one stream.