Skip to content

MNT: Remove unused legacy spectral.cu#7556

Merged
rapids-bot[bot] merged 6 commits intorapidsai:mainfrom
mani-builds:remove-legacy-spectral-cu-enh
Dec 4, 2025
Merged

MNT: Remove unused legacy spectral.cu#7556
rapids-bot[bot] merged 6 commits intorapidsai:mainfrom
mani-builds:remove-legacy-spectral-cu-enh

Conversation

@mani-builds
Copy link
Copy Markdown
Contributor

This removes the long-dead cpp/src/spectral/spectral.cu file and its last remaining reference in the top-level CMakeLists.txt.

The file has been unused since the spectral clustering refactor in 2021 and is no longer compiled or required.

Closes #7538

@mani-builds mani-builds requested review from a team as code owners December 2, 2025 17:52
@mani-builds mani-builds requested a review from vyasr December 2, 2025 17:52
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Dec 2, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mani-builds mani-builds changed the title MNT: Remove unused legacy spectral.cu (Non-breaking) MNT: Remove unused legacy spectral.cu (non-breaking) Dec 2, 2025
@csadorf csadorf added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2025
@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Dec 2, 2025

@mani-builds Please refrain from merging origin/main unless there are particular updates you need to integrate from the upstream branch or our bot warns explicitly that the PR branch is too far behind. This is to reduce CI churn on our end. Thank you.

@mani-builds
Copy link
Copy Markdown
Contributor Author

@mani-builds Please refrain from merging origin/main unless there are particular updates you need to integrate from the upstream branch or our bot warns explicitly that the PR branch is too far behind. This is to reduce CI churn on our end. Thank you.

Understood, thanks for the feedback.

@csadorf
Copy link
Copy Markdown
Contributor

csadorf commented Dec 2, 2025

/ok to test 8688a02

@csadorf csadorf changed the title MNT: Remove unused legacy spectral.cu (non-breaking) MNT: Remove unused legacy spectral.cu Dec 2, 2025
@aamijar aamijar requested review from aamijar and removed request for vyasr December 3, 2025 08:07
@aamijar
Copy link
Copy Markdown
Member

aamijar commented Dec 3, 2025

/ok to test 7a33489

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Dec 3, 2025

/ok to test c99ec1a

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Dec 3, 2025

/ok to test 2526b98

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Dec 4, 2025

/ok to test e16b8f3

@aamijar
Copy link
Copy Markdown
Member

aamijar commented Dec 4, 2025

/merge

@rapids-bot rapids-bot Bot merged commit b46fd5f into rapidsai:main Dec 4, 2025
200 of 202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CUDA/C++ improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove legacy spectral.cu

5 participants