Remove verbose descriptor#7527
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Nov 24, 2025
Merged
Conversation
jcrist
added
Cython / Python
jcrist
commented
Nov 22, 2025
This is now just a regular attribute, we convert to a `level_enum` when needed to forward to the `libcuml` API. In the future we'll remove this forwarding entirely in favor of configuring the logger contextually outside of the libcuml calls.
jcrist
force-pushed
the
remove-verbose-descriptor
branch
from
07ae0cd to
c7e8f32
Compare
jcrist
commented
Nov 23, 2025
csadorf
approved these changes
Nov 24, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
verboseattribute on an estimator had some magic in it where the value when accessed internally would be acuml.internals.logger.level_enum, but externally would be anintorboolvalue as described by the public API.This PR removes that magic in favor of simpler mechanisms. Now
model.verboseis a normal attribute, andmodel._verbose_levela property that convertsmodel.verboseto alevel_enum.Part of #5022.