Skip to content

Cleanup cuml.multiclass#7508

Merged
rapids-bot[bot] merged 3 commits intorapidsai:release/25.12from
jcrist:cleanup-multiclass
Nov 19, 2025
Merged

Cleanup cuml.multiclass#7508
rapids-bot[bot] merged 3 commits intorapidsai:release/25.12from
jcrist:cleanup-multiclass

Conversation

@jcrist
Copy link
Copy Markdown
Member

@jcrist jcrist commented Nov 19, 2025

This:

  • Cleans up our multiclass implementations slightly. In the future we'll want to do redo these implementations so we're not just wrappers around sklearn (requiring host transfers etc...), but for now at least we're following conventions in [TRACKER] Cleanup python estimator implementations #7317.
  • Deprecates MulticlassClassifier in favor of OneVsOneClassifier/OneVsRestClassifier. This is to reduce our estimator maintenance a bit - sklearn only provides the latter 2, no need for us to add another estimator class.

Part of #7317.

@jcrist jcrist requested a review from a team as a code owner November 19, 2025 17:57
@jcrist jcrist requested a review from csadorf November 19, 2025 17:57
@github-actions github-actions Bot added the Cython / Python Cython or Python issue label Nov 19, 2025
@jcrist jcrist changed the base branch from main to release/25.12 November 19, 2025 17:58
@jcrist jcrist added improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 19, 2025
Copy link
Copy Markdown
Member

@aamijar aamijar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Comment thread python/cuml/cuml/multiclass/multiclass.py
Comment thread python/cuml/cuml/multiclass/multiclass.py
Comment thread python/cuml/cuml/multiclass/multiclass.py
@jcrist
Copy link
Copy Markdown
Member Author

jcrist commented Nov 19, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 21c5182 into rapidsai:release/25.12 Nov 19, 2025
116 checks passed
@jcrist jcrist deleted the cleanup-multiclass branch November 19, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants