Rename TSNE n_iter to max_iter#7500
Merged
rockhowse merged 2 commits intorapidsai:release/25.12from Nov 18, 2025
Merged
Conversation
jcrist
added
improvement
In scikit-learn 1.5 they renamed the TSNE `n_iter` parameter to `max_iter`. In the interest of maximizing sklearn compatibility, here we do the same. This PR deprecates `n_iter` in favor of `max_iter`, in 26.02 we'll remove `n_iter` completely.
jcrist
force-pushed
the
rename-tsne-n-iter
branch
from
fc82e36 to
d32aba2
Compare
betatim
approved these changes
Nov 18, 2025
Member
betatim
left a comment
betatim
left a comment
There was a problem hiding this comment.
LGTM.
The formatting change to __init__ is on purpose or due to us changing formatting tool? Just to know if we should expect to see more of this in the future. Makes it minimally harder to figure out if the only thing that effectively changed is the value of n_iter
Member
|
Restarted the failed build job. Looked like a networking error fetching the nccl package from anaconda.org |
Co-authored-by: Tim Head <[email protected]>
csadorf
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In scikit-learn 1.5 they renamed the TSNE
n_iterparameter tomax_iter. In the interest of maximizing sklearn compatibility, here we do the same. This PR deprecatesn_iterin favor ofmax_iter, in 26.02 we'll removen_itercompletely.