Deprecate normalize option to all linear models#7415
Merged
rapids-bot[bot] merged 1 commit intorapidsai:mainfrom Oct 31, 2025
Merged
Deprecate normalize option to all linear models#7415rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
normalize option to all linear models#7415rapids-bot[bot] merged 1 commit intorapidsai:mainfrom
Conversation
This deprecates the `normalize` option to all linear models that still supported it. It includes one _potentially_ breaking change. `cuml.experimental.linear_model.Lars` was documented to have `normalize` default to `False` (and clearly should have), but still had it default to `True`. Since it's in the experimental namespace and feels like a bug to me I've updated the value here to `False` with no deprecation period. The tests had to have their tolerance slightly expanded. AFAICT no model was testing (intentionally) with `normalize=True` anywhere, which makes me feel pretty confident that we should rip this option out. There's no way to ensure it was even doing the right thing anymore.
jcrist
added
Cython / Python
viclafargue
approved these changes
Oct 31, 2025
Contributor
viclafargue
left a comment
viclafargue
left a comment
There was a problem hiding this comment.
LGTM, just minor things
Member
Author
|
/merge |
vardhan30016
pushed a commit
to vardhan30016/cuml
that referenced
this pull request
Nov 7, 2025
This deprecates the `normalize` option to all linear models that still supported it. It includes one _potentially_ breaking change (I'm viewing it more as a bug-fix). `cuml.experimental.linear_model.Lars` was documented to have `normalize` default to `False` (and clearly should have), but still had it default to `True`. Since it's in the experimental namespace and feels like a bug to me I've updated the value here to `False` with no deprecation period. The tests had to have their tolerance slightly expanded. AFAICT no model was testing (intentionally) with `normalize=True` anywhere, which makes me feel pretty confident that we should rip this option out. There's no way to ensure it was even doing the right thing anymore. Fixes rapidsai#7400. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Victor Lafargue (https://github.com/viclafargue) URL: rapidsai#7415
rapids-bot Bot
pushed a commit
that referenced
this pull request
Dec 15, 2025
This: - Removes the deprecated `normalize` parameter from all affected models (`cuml.linear_model`/`cuml.dask.linear_model`) - Removes support for `normalize` at the C++ level as well - Updates the C++ tests accordingly (mostly just deleting no longer necessary test cases) Follow-up to #7415. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Anupam (https://github.com/aamijar) - Dante Gama Dessavre (https://github.com/dantegd) URL: #7611
mani-builds
pushed a commit
to mani-builds/cuml
that referenced
this pull request
Jan 11, 2026
This: - Removes the deprecated `normalize` parameter from all affected models (`cuml.linear_model`/`cuml.dask.linear_model`) - Removes support for `normalize` at the C++ level as well - Updates the C++ tests accordingly (mostly just deleting no longer necessary test cases) Follow-up to rapidsai#7415. Authors: - Jim Crist-Harif (https://github.com/jcrist) Approvers: - Anupam (https://github.com/aamijar) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#7611
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This deprecates the
normalizeoption to all linear models that still supported it.It includes one potentially breaking change (I'm viewing it more as a bug-fix).
cuml.experimental.linear_model.Larswas documented to havenormalizedefault toFalse(and clearly should have), but still had it default toTrue. Since it's in the experimental namespace and feels like a bug to me I've updated the value here toFalsewith no deprecation period. The tests had to have their tolerance slightly expanded.AFAICT no model was testing (intentionally) with
normalize=Trueanywhere, which makes me feel pretty confident that we should rip this option out. There's no way to ensure it was even doing the right thing anymore.Fixes #7400.