Fix Dask DBSCAN tree reduction#7398
Merged
rapids-bot[bot] merged 2 commits intorapidsai:mainfrom Oct 30, 2025
Merged
Conversation
jcrist
approved these changes
Oct 28, 2025
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Mostly LGTM. Was there a test before that would fail when run on a multi-gpu system? If not, is there an easy way to add one?
Contributor
Author
Almost all of the existing tests would hang when ran on more than 2 GPUs. |
divyegala
approved these changes
Oct 29, 2025
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7341
The tree reduction operation of Dask DBSCAN had an issue. The communicator was waiting for communication request completion even when none was ordered (passive rank) causing a deadlock.
Additionally, there was an issue with the UCX comms being set with an incorrect number of ranks when Dask workers fail to register to the scheduler.