Don't infer dtype from model in cuml.explainer#7358
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from Oct 17, 2025
Merged
Don't infer dtype from model in cuml.explainer#7358rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
cuml.explainer#7358rapids-bot[bot] merged 1 commit intorapidsai:branch-25.12from
Conversation
jcrist
added
Cython / Python
csadorf
approved these changes
Oct 17, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Looks good. I have one change request.
jcrist
force-pushed
the
explainer-no-dtype-infer
branch
from
dcf505c to
3d6d9b3
Compare
Previously the classes in `cuml.explainer` would try to infer the dtype of the model function from `func.__self__.dtype`. This only worked for some models (only those that exposed an undocumented `.dtype` attribute), and led to inconsistent behavior between model functions. As we cleanup our model internals we're also removing the `.dtype` attribute from models, so this method no longer works. Aiming for consistency, we change the default of `dtype` in `cuml.explainer` to `float32` everywhere - if a user wants to use `float64` they'll need to specify it manually.
jcrist
force-pushed
the
explainer-no-dtype-infer
branch
from
3d6d9b3 to
631a6f9
Compare
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the classes in
cuml.explainerwould try to infer the dtype of the model function fromfunc.__self__.dtype. This only worked for some models (only those that exposed an undocumented.dtypeattribute), and led to inconsistent behavior between model functions. As we cleanup our model internals we're also removing the.dtypeattribute from models, so this method no longer works.Aiming for consistency, we change the default of
dtypeincuml.explainertofloat32everywhere - if a user wants to usefloat64they'll need to specify it manually.