Skip to content

Provide a static target for libcuml#7351

Merged
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.12from
divyegala:cuml-static
Oct 16, 2025
Merged

Provide a static target for libcuml#7351
rapids-bot[bot] merged 7 commits intorapidsai:branch-25.12from
divyegala:cuml-static

Conversation

@divyegala
Copy link
Copy Markdown
Member

@divyegala divyegala commented Oct 16, 2025

Closes #7024

Furthermore, this PR has a longer changelist that includes:

  1. cmake-format and cmake-lint in pre-commit configuration
  2. Removing CUML_USE_RAFT_STATIC and CUML_USE_CUMLPRIMS_MG_STATIC CMake options (no static targets for either exist)
  3. Cleaning up unused options in get_raft.cmake and get_cumlprims_mg.cmake
  4. Removing CUML_EXPORT_TREELITE_LINKAGE because it should always be a PUBLIC link. We have several headers that include treelite headers.

@divyegala divyegala self-assigned this Oct 16, 2025
@divyegala divyegala requested review from a team as code owners October 16, 2025 01:01
@divyegala divyegala added the feature request New feature or request label Oct 16, 2025
@divyegala divyegala added the non-breaking Non-breaking change label Oct 16, 2025
@divyegala divyegala requested a review from bdice October 16, 2025 01:01
@github-actions github-actions Bot added Cython / Python Cython or Python issue CMake CUDA/C++ labels Oct 16, 2025
Comment thread cpp/CMakeLists.txt Outdated
Comment thread cpp/CMakeLists.txt Outdated
Comment thread python/libcuml/CMakeLists.txt Outdated
divyegala and others added 2 commits October 16, 2025 13:31
@divyegala
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot Bot merged commit 3613d42 into rapidsai:branch-25.12 Oct 16, 2025
200 of 202 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CUDA/C++ Cython / Python Cython or Python issue feature request New feature or request non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a libcuml static target

3 participants