Fix flaky test_logistic_regression_weighting test#7321
Merged
rapids-bot[bot] merged 13 commits intorapidsai:branch-25.12from Oct 16, 2025
Merged
Fix flaky test_logistic_regression_weighting test#7321rapids-bot[bot] merged 13 commits intorapidsai:branch-25.12from
test_logistic_regression_weighting test#7321rapids-bot[bot] merged 13 commits intorapidsai:branch-25.12from
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 557fee1 |
Contributor
Author
|
/ok to test d849ced |
Contributor
Author
|
/ok to test e86e662 |
test_logistic_regression_weighting test
viclafargue
approved these changes
Oct 16, 2025
Contributor
Author
|
/merge |
952456a
into
rapidsai:branch-25.12
190 of 192 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
test_logistic_regression_weightingto use Hypothesis for property-based testing, fixing flakiness in multiclass logistic regression with class weighting.Closes #7298
Problem
The
test_logistic_regression_weighting[multiclass-3-class_weight]test was failing intermittently. The root causes:keepdims=Truein multiclass coefficient normalizationChanges
Converted to Hypothesis-based testing:
standard_classification_datasets()withuse_sample_weightandclass_weight_optionparameters@exampledecorators for critical scenarios (including the original failing case)Improved robustness:
unit_tol=0.04, total_tol=0.08unit_tol=0.25, total_tol=0.40