Add SparseRandomProjection, AgglomerativeClustering and GaussianRandomProjection to common checks#7307
Merged
rapids-bot[bot] merged 8 commits intorapidsai:branch-25.12from Oct 15, 2025
Conversation
betatim
added
improvement
betatim
changed the title
Performing this check leads to memory errors down the line in unrelated tests.
…tests-2' into add-random-projection-to-common-tests-2
…tests-2' into add-random-projection-to-common-tests-2
jcrist
approved these changes
Oct 15, 2025
Member
jcrist
left a comment
jcrist
left a comment
There was a problem hiding this comment.
Seems fine to me.
Two questions:
- Given one of the tests is skipped due to causing memory errors, did you run this a few times successfully (at least locally) to see if anything else shakes out?
- Are these xfails strict (meaning if we fix a bug they'll start failing until they're un-xfailed)?
Member
Author
|
If I run (just) the tests in The tests aren't running in strict mode. I'd prefer to do that in a new PR. |
Member
|
/merge |
rapids-bot
Bot
merged commit 029a307
into
rapidsai:branch-25.12
190 of 192 checks passed
Member
Author
|
meh, |
Contributor
Can we make sure to track this in a follow-up issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revived version of #7136 and #7135