[FEA] Implement kfold.#7296
Merged
rapids-bot[bot] merged 24 commits intorapidsai:mainfrom Oct 31, 2025
Merged
Conversation
trivialfis
added
feature request
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
- remove custom random state handling. - remove type hints. - update doc strings.
trivialfis
force-pushed
the
fea-kfold-rebase
branch
from
29967cb to
8143b43
Compare
Contributor
|
@trivialfis Please let us know when this is ready for review. Thank you! |
Member
Author
|
@csadorf It's ready now. |
trivialfis
added
3 - Ready for Review
csadorf
requested changes
Oct 14, 2025
Contributor
csadorf
left a comment
csadorf
left a comment
There was a problem hiding this comment.
Thank you for re-opening this PR!
I have change requests and suggestions.
| n_splits=n_splits, shuffle=shuffle, random_state=random_state | ||
| ) | ||
|
|
||
| def split(self, x, y=None): |
Contributor
There was a problem hiding this comment.
This should be an uppercase X.
Suggested change
| def split(self, x, y=None): | |
| def split(self, X, y=None): |
Member
Author
|
All passed. |
Contributor
|
/merge |
vardhan30016
pushed a commit
to vardhan30016/cuml
that referenced
this pull request
Nov 7, 2025
rapidsai#7163 rebased onto branch-25.12. Closes rapidsai#7088 Continuing the previous PR: - I have confirmed that the document from the base class `get_n_splits` is correctly inherited for the `KFold`. - I did not add the `StratifiedKFold` to the Sphinx doc as it did not build successfully. And as previously suggested, changing the stratified kfold should not be bundled into this PR. - Added a more precise test for the fold size. *todos* - [x] rapidsai#7163 (comment) Authors: - Jiaming Yuan (https://github.com/trivialfis) - Divye Gala (https://github.com/divyegala) - Simon Adorf (https://github.com/csadorf) Approvers: - Simon Adorf (https://github.com/csadorf) URL: rapidsai#7296
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7163 rebased onto branch-25.12.
Closes #7088
Continuing the previous PR:
get_n_splitsis correctly inherited for theKFold.StratifiedKFoldto the Sphinx doc as it did not build successfully. And as previously suggested, changing the stratified kfold should not be bundled into this PR.todos