Skip to content

Add NCCL library path to CMakeLists.txt for libcuml#7281

Merged
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
csadorf:fix/issue-7277
Sep 30, 2025
Merged

Add NCCL library path to CMakeLists.txt for libcuml#7281
rapids-bot[bot] merged 2 commits intorapidsai:branch-25.10from
csadorf:fix/issue-7277

Conversation

@csadorf
Copy link
Copy Markdown
Contributor

@csadorf csadorf commented Sep 29, 2025

Closes #7277.

@csadorf csadorf requested a review from a team as a code owner September 29, 2025 20:36
@csadorf csadorf requested a review from dantegd September 29, 2025 20:36
@github-actions github-actions Bot added Cython / Python Cython or Python issue CMake labels Sep 29, 2025
@csadorf csadorf added bug Something isn't working non-breaking Non-breaking change labels Sep 29, 2025
@jcrist
Copy link
Copy Markdown
Member

jcrist commented Sep 29, 2025

The issue doesn't appear to show up in any of the builds we run on PRs (but does on nightlies). Have you verified this fixes things locally somehow?

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Sep 29, 2025

The issue doesn't appear to show up in any of the builds we run on PRs (but does on nightlies). Have you verified this fixes things locally somehow?

Thanks for pointing that out. The PR CI will build the wheel that we can test locally.

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Sep 30, 2025

Confirmed locally that the issues we observe in #7277 are resolved with the wheel build in this pipeline.

@csadorf
Copy link
Copy Markdown
Contributor Author

csadorf commented Sep 30, 2025

/merge

@rapids-bot rapids-bot Bot merged commit 9c09d16 into rapidsai:branch-25.10 Sep 30, 2025
101 checks passed
@csadorf csadorf deleted the fix/issue-7277 branch September 30, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CMake Cython / Python Cython or Python issue non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] NCCL version mismatch causing undefined symbol ncclCommSplit in Dask tests

4 participants